You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There are several instances in the consensus critical code path in blockchain and stake that call txscript.ExtractPkScriptAddrs however, as indicated by being in the standard.go file, that function is only intended explicitly for working with standard script forms which only apply in the context of the more restrictive standardness policy rules (e.g. what is permitted to enter to the mempool and be relayed across the network) as opposed to the consensus rules.
This is important because the standardness rules can, and do, change over time independently of the consensus rules, whereas the consensus rules must not change without an explicit vote since it constitutes a fork.
Consequently, every reference to the function in the consensus critical code paths in blockchain and stake must be replaced to explicitly enforce the exact semantics expected by the current consensus rules.
The text was updated successfully, but these errors were encountered:
davecgh
changed the title
blockchain/stake: Remove all consensus calls to ExtractPkScriptAddrs.
blockchain/stake: Replace all consensus calls to ExtractPkScriptAddrs.
Feb 17, 2019
There are several instances in the consensus critical code path in
blockchain
andstake
that calltxscript.ExtractPkScriptAddrs
however, as indicated by being in thestandard.go
file, that function is only intended explicitly for working with standard script forms which only apply in the context of the more restrictive standardness policy rules (e.g. what is permitted to enter to the mempool and be relayed across the network) as opposed to the consensus rules.This is important because the standardness rules can, and do, change over time independently of the consensus rules, whereas the consensus rules must not change without an explicit vote since it constitutes a fork.
Consequently, every reference to the function in the consensus critical code paths in
blockchain
andstake
must be replaced to explicitly enforce the exact semantics expected by the current consensus rules.The text was updated successfully, but these errors were encountered: