Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blockchain/stake: Replace all consensus calls to ExtractPkScriptAddrs. #1625

Closed
davecgh opened this issue Feb 17, 2019 · 2 comments
Closed
Labels
non-forking consensus Changes that involve modifying consensus code without causing any forking changes.

Comments

@davecgh
Copy link
Member

davecgh commented Feb 17, 2019

There are several instances in the consensus critical code path in blockchain and stake that call txscript.ExtractPkScriptAddrs however, as indicated by being in the standard.go file, that function is only intended explicitly for working with standard script forms which only apply in the context of the more restrictive standardness policy rules (e.g. what is permitted to enter to the mempool and be relayed across the network) as opposed to the consensus rules.

This is important because the standardness rules can, and do, change over time independently of the consensus rules, whereas the consensus rules must not change without an explicit vote since it constitutes a fork.

Consequently, every reference to the function in the consensus critical code paths in blockchain and stake must be replaced to explicitly enforce the exact semantics expected by the current consensus rules.

@davecgh davecgh changed the title blockchain/stake: Remove all consensus calls to ExtractPkScriptAddrs. blockchain/stake: Replace all consensus calls to ExtractPkScriptAddrs. Feb 17, 2019
@dnldd
Copy link
Member

dnldd commented Feb 22, 2019

On it.

@davecgh davecgh added the non-forking consensus Changes that involve modifying consensus code without causing any forking changes. label Dec 28, 2019
@davecgh davecgh closed this as completed Feb 12, 2020
@davecgh
Copy link
Member Author

davecgh commented Feb 12, 2020

This was resolved by recent updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
non-forking consensus Changes that involve modifying consensus code without causing any forking changes.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants