Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add French translation #423

Merged
merged 10 commits into from
Apr 12, 2020
Merged

feat: add French translation #423

merged 10 commits into from
Apr 12, 2020

Conversation

jdambron
Copy link
Contributor

French Translation

@jdambron
Copy link
Contributor Author

I am not sure why the build is crashing. I do not see the relation with the file I added.
If I can help in any way, let me know.

beansgum
beansgum approved these changes Apr 12, 2020
View reviewed changes
Copy link
Contributor

@beansgum beansgum left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to update with a fresh translation of strings.xml. Some string values have changed and I don't know when you got your version of strings.xml so It's not possible for me to know what strings you need to update.

Screenshot from test:

@beansgum beansgum merged commit 7ab98aa into planetdecred:master Apr 12, 2020
@jdambron jdambron deleted the French-translation branch April 14, 2020 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beansgum beansgum beansgum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdambron @beansgum