restore wallet: remove RecyclerView and use a custom populated layout #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The RecylerView used in restore wallet activity was not the best choice as its values in the text field gets mixed up when scrolling and sometimes the text visible isn't the value validated. This fixes the issues by replacing the RecyclerView with a LinearLayout and the views have their exclusive scope rather than operating under RecyclerView and that prevents mixup from happening between text fields.
- send: fix send page crash when sending in background(planetdecred#410). - overivew: show confirmation dialog before exiting app. - debug: move wallet log above statistics.
dreacot
approved these changes
Jan 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RecylerView used in restore wallet activity was not the best choice as its values in the text field gets mixed up when scrolling and sometimes the text visible isn't the value validated. This fixes the issues by replacing the RecyclerView with a LinearLayout and the views have their exclusive scope rather than operating under RecyclerView and that prevents mixup from happening between text fields.
Crash when sending was also fixed by using the function
dismissAllowingStateLoss()instead ofdismiss(). The crash was caused by state loss when dismissing dialog in background.Closes #410 & #408