Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[proposal] update list of managed DIDs and keys based on KMS implementations #932

Open
mirceanis opened this issue Jun 13, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request incomplete Issue is not well defined. Please ask for clarification before starting to work on it! pinned don't close this just for being stale

Comments

@mirceanis
Copy link
Member

Based on a commend in #924

In @veramo/kms-web3, the way key metadata is stored by other plugins matters a lot.
The key metadata, the controllerKeyId and kid of the key must all align properly for kms-web3 to be able to find the right provider and call it to sign.

Also, if web3 providers change, there should also be some update to the managed DIDs and keys from @veramo/did-manager / @veramo/key-manager.

It is likely that an initialization step is necessary to allow the DIDManager and KeyManager plugins to inspect the KMS implementations for the lists of available keys and then decide to enable/disable their own entries accordingly.

@mirceanis mirceanis added enhancement New feature or request incomplete Issue is not well defined. Please ask for clarification before starting to work on it! pinned don't close this just for being stale labels Jun 13, 2022
@mirceanis mirceanis added this to the v4 milestone Jun 13, 2022
@mirceanis mirceanis self-assigned this Jul 28, 2022
@mirceanis mirceanis removed this from the v4 milestone Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request incomplete Issue is not well defined. Please ask for clarification before starting to work on it! pinned don't close this just for being stale
Projects
None yet
Development

No branches or pull requests

2 participants