Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): remove revocable and send options from credential create command #1345

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

mirceanis
Copy link
Member

What issue is this PR fixing

fixes #1342

What is being changed

The veramo credential create command would ask if the credential being created should be revokable but would then use an incompletely supported credentialStatus method, making the credentials unverifiable (using default configs).
Since the command is (still) meant as a simple demo, it's easier to simply remove that option.

Additionally, the credential is now getting saved using data-store API instead of the deprecated save option and the verification is a bit more lenient with JSON5 inputs.

Quality

Check all that apply:

  • I want these changes to be integrated
  • I successfully ran pnpm i, pnpm build, pnpm test, pnpm test:browser locally.
  • I allow my PR to be updated by the reviewers (to speed up the review process).
  • I added unit tests.
  • I added integration tests.
  • I did not add automated tests because we don't yet have a test harness for the CLI, and I am aware that a PR without tests will likely get rejected.

@mirceanis mirceanis added this to the v6 milestone Feb 22, 2024
@nickreynolds nickreynolds merged commit 8697e97 into next Feb 22, 2024
10 checks passed
@nickreynolds nickreynolds deleted the 1342-cli-credential-status branch February 22, 2024 17:27
mirceanis added a commit that referenced this pull request Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants