fix(cli): remove revocable
and send
options from credential create command
#1345
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue is this PR fixing
fixes #1342
What is being changed
The
veramo credential create
command would ask if the credential being created should be revokable but would then use an incompletely supported credentialStatus method, making the credentials unverifiable (using default configs).Since the command is (still) meant as a simple demo, it's easier to simply remove that option.
Additionally, the credential is now getting saved using data-store API instead of the deprecated
save
option and the verification is a bit more lenient with JSON5 inputs.Quality
Check all that apply:
pnpm i
,pnpm build
,pnpm test
,pnpm test:browser
locally.