Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: export const plugin schemas instead of defaults #1327

Merged
merged 2 commits into from
Jan 25, 2024

Conversation

mirceanis
Copy link
Member

What issue is this PR fixing

relates to #1318 / #1317 / #1315

What is being changed

The plugin schema generator is using export const schema = {...} instead of export default {}.
This also requires the imports to change.
I also took the opportunity to export the regenerated schemas from the relevant packages as well as to remove any reference to the previous JSON outputs.

Quality

Check all that apply:

  • I want these changes to be integrated
  • I successfully ran pnpm i, pnpm build, pnpm test, pnpm test:browser locally.
  • I allow my PR to be updated by the reviewers (to speed up the review process).
  • I added unit tests.
  • I added integration tests.
  • I did not add automated tests because this is more of a build issue

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (71e313f) 68.19% compared to head (0788ed7) 89.83%.

Additional details and impacted files
@@             Coverage Diff             @@
##             next    #1327       +/-   ##
===========================================
+ Coverage   68.19%   89.83%   +21.63%     
===========================================
  Files         176      176               
  Lines       27002    27010        +8     
  Branches     2121     2120        -1     
===========================================
+ Hits        18415    24265     +5850     
+ Misses       8587     2745     -5842     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@cre8 cre8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ty for the fix

@mirceanis mirceanis merged commit 7896cea into next Jan 25, 2024
9 checks passed
@mirceanis mirceanis deleted the plugin-schema-export-const branch January 25, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants