Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): add 'ethers@^6.7.1' dependency #1304

Merged
merged 1 commit into from
Dec 12, 2023
Merged

fix(deps): add 'ethers@^6.7.1' dependency #1304

merged 1 commit into from
Dec 12, 2023

Conversation

hylim-tech-lover
Copy link
Contributor

closes #1295

What is being changed

Fix missing ethers dependency that utilized in each relevant modules.

Quality

Check all that apply:

  • I want these changes to be integrated
  • I successfully ran pnpm i, pnpm build, pnpm test, pnpm test:browser locally.
  • I allow my PR to be updated by the reviewers (to speed up the review process).
  • I added unit tests.
  • I added integration tests.
  • I did not add automated tests because _________, and I am aware that a PR without tests will likely get rejected.

Details

If applicable, add screen captures, error messages or stack traces to help explain your problem.

@hylim-tech-lover
Copy link
Contributor Author

Ready for PR review.

Have used ethers: ^6.7.1 to standardize with @veramo/utils modules

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (572e08d) 85.47% compared to head (1efafcf) 85.47%.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #1304   +/-   ##
=======================================
  Coverage   85.47%   85.47%           
=======================================
  Files         170      170           
  Lines       18950    18950           
  Branches     2115     2115           
=======================================
  Hits        16197    16197           
  Misses       2753     2753           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mirceanis mirceanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for spotting and fixing this!

@mirceanis mirceanis merged commit 2157e70 into decentralized-identity:next Dec 12, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ethers dependency missing on veramo modules
3 participants