Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for DIDCommv3 Coordinate Mediation #1255

Closed
radleylewis opened this issue Sep 25, 2023 · 5 comments · Fixed by #1282
Closed

Add Support for DIDCommv3 Coordinate Mediation #1255

radleylewis opened this issue Sep 25, 2023 · 5 comments · Fixed by #1282
Labels
enhancement New feature or request pinned don't close this just for being stale

Comments

@radleylewis
Copy link
Contributor

Overview

Veramo has already implemented DIDComm v2 Coordinate Mediation. With the recently released DIDComm v3 Specification for Coordinate Mediation, the work already done in this PR will need to be updated.

Solution

Would you be open to contributions to transfer the existing implementation to v3?

Resources

@radleylewis radleylewis added the enhancement New feature or request label Sep 25, 2023
@nickreynolds
Copy link
Contributor

We're always open to contributions and would love a PR implementing v3 of this protocol.

@radleylewis
Copy link
Contributor Author

Sounds good. Did I need to set up any specific permissions to push my branch up? I am following the contribution guidelines branding off main but am getting a permission denied (403).

@mirceanis
Copy link
Member

Sounds good. Did I need to set up any specific permissions to push my branch up? I am following the contribution guidelines branding off main but am getting a permission denied (403).

The way it's normally done, is that you fork the repository and push to your fork. Then the PR is made from your fork to veramo

@radleylewis
Copy link
Contributor Author

@mirceanis thanks for the clarification. The makes sense.

Copy link

stale bot commented Dec 1, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Dec 1, 2023
@mirceanis mirceanis added the pinned don't close this just for being stale label Dec 2, 2023
@stale stale bot removed the wontfix This will not be worked on label Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request pinned don't close this just for being stale
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants