Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[proposal] Add AES and NIST curve support to the DIDComm implementation #1083

Closed
mirceanis opened this issue Dec 2, 2022 · 0 comments · Fixed by #1180
Closed

[proposal] Add AES and NIST curve support to the DIDComm implementation #1083

mirceanis opened this issue Dec 2, 2022 · 0 comments · Fixed by #1180
Labels
dependencies Refers to an update of a dependency file enhancement New feature or request incomplete Issue is not well defined. Please ask for clarification before starting to work on it! pinned don't close this just for being stale

Comments

@mirceanis
Copy link
Member

mirceanis commented Dec 2, 2022

We're currently using only X25519 keys with ECDH-ES or ECDH-1PU + XC20P for key agreement and wrapping, and XC20P for content encryption, but XC20P is only listed as optional:
https://identity.foundation/didcomm-messaging/spec/#curves-and-content-encryption-algorithms

We need AES support for content encryption and key wrapping and P256 & P384 key support too. to be fully spec compliant in terms of algorithms.

It's likely that these features will have to be implemented in the lower level did-jwt library which is being used for JWE.
I believe that @stablelib (the lib that is used for encryption support) should already have all the primitives needed.

@mirceanis mirceanis added enhancement New feature or request dependencies Refers to an update of a dependency file incomplete Issue is not well defined. Please ask for clarification before starting to work on it! pinned don't close this just for being stale labels Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Refers to an update of a dependency file enhancement New feature or request incomplete Issue is not well defined. Please ask for clarification before starting to work on it! pinned don't close this just for being stale
Projects
None yet
1 participant