Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix getRealm implementation #3040

Open
fcolarich opened this issue Dec 26, 2024 · 0 comments
Open

fix getRealm implementation #3040

fcolarich opened this issue Dec 26, 2024 · 0 comments
Assignees
Labels
1-high Very important but not critical or game breaking

Comments

@fcolarich
Copy link
Collaborator

fcolarich commented Dec 26, 2024

Pasted from Slack thread:

Sergey D.
Yes, we've figured it out. The problem is that getRealm in E@ misses baseUrl prop. Instead, it has domain . If it's intentional change (why, btw?) - it should be reflected in rewards api doc, because right now there is baseUrl used in example.

Also, SDK definition for getRealm response lacks that domain prop, too. So we had to do a bit of dirty //@ts-ignore magic.

@fcolarich fcolarich self-assigned this Dec 26, 2024
@github-actions github-actions bot added the new Issues to triage label Dec 26, 2024
@fcolarich fcolarich added 1-high Very important but not critical or game breaking and removed new Issues to triage labels Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1-high Very important but not critical or game breaking
Projects
None yet
Development

No branches or pull requests

1 participant