feat: fail if the tx is dropped

[nicosantangelo]

also removes repeated code for fetching transaction statuses.

The idea is to make waitForCompletion aware of dropped transactions, which return as null, but give it some time to wait in case there's congestion (hence the retriesOnEmpty).

I'm not in love with the impl, comments are welcomed

[menduz]

Can we make this a configurable function parameter with a default value?

[menduz]

Since we have a discrete number of amounts to iterate, we could replace the implementation by a for-loop an it would be cleaner

[nicosantangelo]

Kind of, because the idea is to wait until the transaction ends or it's dropped. I'm thinking this is a better implementation

  export async function waitForCompletion(txId: string, retriesOnEmpty: number = 5): Promise<any> {
    const isDropped = await isTxDropped(txId, retriesOnEmpty)
    if (isDropped) {
      return { hash: txId, status: TRANSACTION_STATUS.failed }
    }

    while (true) {
      const tx = await getTransaction(txId)
      
      if (!isPending(tx) && tx.recepeit) {
        return tx
      }

      await sleep(TRANSACTION_FETCH_DELAY)
    }
  }

  export async function isTxDropped(txId: string, retryAttemps: number = 5) : boolean {
    while (retryAttemps > 0) {
      const tx = await getTransaction(txId)

      if (tx !== null) {
        return false
      }

      retryAttemps -= 1
      await sleep(TRANSACTION_FETCH_DELAY)
    }

    return true
  }

what do you think?

[menduz]

[nicosantangelo]

Let me rebase and squash so it looks cleaner!

Edit: Done!