Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to turn off moving of input files #205

Closed
robintw opened this issue Mar 12, 2020 · 3 comments · Fixed by #216
Closed

Add ability to turn off moving of input files #205

robintw opened this issue Mar 12, 2020 · 3 comments · Fixed by #216
Assignees

Comments

@robintw
Copy link
Collaborator

robintw commented Mar 12, 2020

I think we discussed this on Slack, but I couldn't see any issue for it. We thought it'd be helpful to be able to turn off the moving of input files for testing purposes (both for us testing the CLI and for the parser writers when testing new parsers, so they don't have to keep moving files back all the time).

This could be an appropriate setting to put into the config file @BarisSari is developing in #202.

@IanMayo
Copy link
Member

IanMayo commented Mar 12, 2020

In my opinion it's something that's more suited to being a parameter for the import.py class.

We wouldn't want to change the shared config file and not archive anybody's files.

Maybe a --archive true / false (default true) flag for import.py .

@BarisSari BarisSari self-assigned this Mar 18, 2020
@BarisSari
Copy link
Contributor

As far as I searched, I think we might have a better flag solution. We might give --archive or --no-archive flags for import.py instead of --archive true/false. Because it might mislead in some cases --archive false can be understood as True because of casting types.

@IanMayo
Copy link
Member

IanMayo commented Mar 18, 2020

Sure, @BarisSari - good thinking. Happy with "flag" strategy.

Hmm, --archive or no-archive. I guess archive is the better strategy. So, by omitting the flag, the files stay in their place, which is the less destructive option.

So, let's go with archive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants