High memory usage over time. - memory leak

[Benchwork]

Operating Systems

Server: windows 10 pro, v1809 build 17763.652

Client: windows 10 Enterprise v1809 build 17134.885

Barrier Version

Server: 2.2.0 & 2.3.1

Client: 2.2.0 & 2.3.1

Steps to reproduce bug

0. installed
1. switch from interactive configuration to file based.
2. reboot both systems and validate all is working,
3. use barrier for a few days, and watch Barriers continue to use more ram.
4. run out of RAM (barriers uses over 4GB of RAM) other programs crash and the resources are
5. Kill process in task manager, Barriers restarts itself and go to step 3.

Other info

• When did the problem start to occur? Slowly over a few days.
• Is there a way to work around it? Yes, you can kill and restart barrier
• Does this bug prevent you from using Barrier entirely? No

maybe related to issue #147

[igordovgaluk]

Memory usage over 3.5GB on the server after less than a day of use.
One client (laptop) connected and disconnected a few times over the period.

client and server v2.2.0 (built from sources) on Ubuntu 18.04

[igordovgaluk]

@shymega there are few memory leak issues reported and resolved
https://github.com/symless/synergy-core/issues/6460
https://github.com/symless/synergy-core/issues/6495

https://github.com/symless/synergy-core/issues?utf8=%E2%9C%93&q=is%3Aissue+memory

[p12tic]

symless#6460 is already addressed in Barrier.

[p12tic]

symless#6495 has been addressed in #409.

[AdrianKoshka]

I'll build a "pre-release" via CI/CD when I get home for testing.

[p12tic]

I saw that there were still some memory usage growth even after the recent fixes, but the magnitude was roughly 10-20 times smaller. So the bug is not completely fixed. Unfortunately full fix is a little more involved as the memory is allocated in area used by multiple threads, so it will take some time.

[AdrianKoshka]

Thanks! Less leakage is better than nothing.

[AdrianKoshka]

If anyone is willing to, it'd be appreciated to test this alpha release which includes some memory leaking alleviation. https://github.com/debauchee/barrier/releases/tag/v2.3.2-alpha

[noisyshape]

@AdrianKoshka I've tested the master branch on Linux and Windows and both look good. SSL connections leak much less and non-SSL connections appear unchanged.

[cowbe0x004]

I'm afraid this is still happening on Windows client. I'm using 2.3.2-alpha. Both server and client use the same version, but the server is fine. This started happening after I updated to Windows 1903 OS build 18362.356.

This is about 5 mins after I started barrier.

EDIT: looks like this is due to encryption. Turned off Enable SSL and it's back to normal.

[salcin]

Hi,

On debian with a VM Windows, barrier freeze completely my computer after somes minutes:

The kernel kill automatically the process of barrier:

[  987.308292] oom-kill:constraint=CONSTRAINT_NONE,nodemask=(null),cpuset=/,mems_allowed=0,global_oom,task_memcg=/user.slice/user-1000.slice/user@1000.service,task=barriers,pid=5826,uid=1000
[  987.308304] Out of memory: Killed process 5826 (barriers) total-vm:6994716kB, anon-rss:6912880kB, file-rss:0kB, shmem-rss:0kB
[  987.430457] oom_reaper: reaped process 5826 (barriers), now anon-rss:0kB, file-rss:0kB, shmem-rss:0kB

The result is the same after have disabled TSL, i use the version 2.3.2+dfsg-1+b1.

[williamoliveira]

It got pretty wild on my machine (Ubuntu 18.04)

Happened at the server after a client disconnected

[isgursoy]

It got pretty wild on my machine (Ubuntu 18.04)

Happened at the server after a client disconnected

for me too

[mirh]

Try with latest git please
#557

[knoriy]

This issue is also happening on Ubuntu 20.04.

[p12tic]

Closing this issue as it's very likely to be fixed in Barrier 2.3.3 (PR #557).