Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fiat currency conversions not recognised #28

Closed
russbrenner opened this issue Nov 3, 2017 · 10 comments
Closed

Fiat currency conversions not recognised #28

russbrenner opened this issue Nov 3, 2017 · 10 comments

Comments

@russbrenner
Copy link

Appears as though fiats that were working in a prior release are no longer recognised.

Have verified they appear in active_currencies.

Running latest 3.2 from git. Removed workflow + leftover files, restarted Alfred, reinstalled, same result.

FIAT symbols tried from USD: AUD, NZD, ZAR.

Screenshots attached.

screenshot 2017-11-03 11 42 20

screenshot 2017-11-03 11 50 00

screenshot 2017-11-03 11 50 40

@thethreeonee
Copy link

same here

@deanishe
Copy link
Owner

deanishe commented Nov 3, 2017

What does the log file say? (Use conv workflow:openlog to open it.)

I'm guessing it's because you haven't set APP_KEY.

@anatolij-p
Copy link

I have similar issue - and I've entered the valid APP_KEY.
For example conv 100 eur usd
unknown unit

@eduwass
Copy link

eduwass commented Nov 3, 2017

Same here, @deanishe here's the log file:

16:26:17 convert.py:315 CRITICAL invalid query (100usd eur): Unknown unit: eur
16:26:23 convert.py:315 CRITICAL invalid query (100usd aud): Unknown unit: aud
16:26:26 convert.py:315 CRITICAL invalid query (100usd gbp): Unknown unit: gbp
16:26:33 convert.py:315 CRITICAL invalid query (100usd nzd): Unknown unit: nzd

Commands I tried were:

conv 100usd eur
conv 100usd aud
conv 100usd gbp
conv 100usd nzd

@anatolij-p
Copy link

OK, my bad. I forgot that first currency has to be joined with the value.
conv 100usd eur works.

So for others that have this problem setup openexchange api key in configuration.

@deanishe
Copy link
Owner

deanishe commented Nov 3, 2017

I forgot that first currency has to be joined with the value

It doesn't. It's likely the workflow updated the exchange rates at some point after you added APP_KEY.

@deanishe
Copy link
Owner

deanishe commented Nov 3, 2017

Same here, @deanishe here's the log file:

@eduwass, that's not enough. Please post all log messages for an entire run where you're getting the error.

@deanishe
Copy link
Owner

deanishe commented Nov 3, 2017

NOTE: The workflow caches exchange rates for several hours. If you've set APP_KEY and can't convert currencies, that's most likely because the old list of exchange rates that doesn't include any fiat currencies hasn't expired yet.

To force a refresh, enter conv workflow:delcache in Alfred.

@eduwass
Copy link

eduwass commented Nov 3, 2017

@deanishe that conv workflow:delcache did the trick, thanks! 👍

@deanishe
Copy link
Owner

deanishe commented Nov 3, 2017

v3.2.1 will clear cached exchange rates when you set APP_KEY and immediately download new rates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants