Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate eclipse-commons library via maven dependency #373

Closed
de-jcup opened this issue Sep 17, 2021 · 2 comments
Closed

Integrate eclipse-commons library via maven dependency #373

de-jcup opened this issue Sep 17, 2021 · 2 comments

Comments

@de-jcup
Copy link
Owner

de-jcup commented Sep 17, 2021

Situation

Currently eclipse-commons library (https://github.com/de-jcup/eclipse-commons) is directly added into lib folder inside Git repository. Having a binary/library inside a GIT repo is normally a very bad idea. (

Wanted

No binary version of eclipse-commons inside GIT any longer

Solution

When #371 has been done and de-jcup/eclipse-commons#30 as well, the dependency management shall reference the eclipse-commons library via maven central and the binary from lib folder shall be removed

@vogella
Copy link
Collaborator

vogella commented Apr 11, 2022

I think we have done this

@vogella vogella closed this as completed Apr 11, 2022
@de-jcup
Copy link
Owner Author

de-jcup commented Apr 16, 2022

Remark: We have done this for the maven - build (#371) . There are still some changes necessary to have the maven build full working, but we have done most parts now and it is okay to close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants