From 34c493d4f797f3a6c0a04d5c8a1e82b936a20a16 Mon Sep 17 00:00:00 2001 From: zverevgeny Date: Mon, 22 Jan 2024 20:02:37 +0300 Subject: [PATCH] YQL-17542 remove function with confusing name CreateKqpTaskRunner (#1183) --- ydb/core/kqp/compute_actor/kqp_scan_compute_actor.cpp | 2 +- ydb/core/kqp/executer_actor/kqp_literal_executer.cpp | 2 +- ydb/core/kqp/runtime/kqp_tasks_runner.cpp | 8 +------- ydb/core/kqp/runtime/kqp_tasks_runner.h | 3 --- 4 files changed, 3 insertions(+), 12 deletions(-) diff --git a/ydb/core/kqp/compute_actor/kqp_scan_compute_actor.cpp b/ydb/core/kqp/compute_actor/kqp_scan_compute_actor.cpp index 709d19bd55ba..c60a029b7dc1 100644 --- a/ydb/core/kqp/compute_actor/kqp_scan_compute_actor.cpp +++ b/ydb/core/kqp/compute_actor/kqp_scan_compute_actor.cpp @@ -219,7 +219,7 @@ void TKqpScanComputeActor::DoBootstrap() { }; } - auto taskRunner = CreateKqpTaskRunner(execCtx, settings, logger); + auto taskRunner = MakeDqTaskRunner(execCtx, settings, logger); TBase::SetTaskRunner(taskRunner); auto wakeup = [this] { ContinueExecute(); }; diff --git a/ydb/core/kqp/executer_actor/kqp_literal_executer.cpp b/ydb/core/kqp/executer_actor/kqp_literal_executer.cpp index 2bab488f0d9f..5156ed69e9d2 100644 --- a/ydb/core/kqp/executer_actor/kqp_literal_executer.cpp +++ b/ydb/core/kqp/executer_actor/kqp_literal_executer.cpp @@ -218,7 +218,7 @@ class TKqpLiteralExecuter { << message); }; - auto taskRunner = CreateKqpTaskRunner(context, settings, log); + auto taskRunner = MakeDqTaskRunner(context, settings, log); TaskRunners.emplace_back(taskRunner); auto taskSettings = NDq::TDqTaskSettings(&protoTask); diff --git a/ydb/core/kqp/runtime/kqp_tasks_runner.cpp b/ydb/core/kqp/runtime/kqp_tasks_runner.cpp index a7f6a7edbab2..ce0f9fc211ac 100644 --- a/ydb/core/kqp/runtime/kqp_tasks_runner.cpp +++ b/ydb/core/kqp/runtime/kqp_tasks_runner.cpp @@ -68,12 +68,6 @@ IDqOutputConsumer::TPtr KqpBuildOutputConsumer(const NDqProto::TTaskOutput& outp } } -TIntrusivePtr CreateKqpTaskRunner(const TDqTaskRunnerContext& execCtx, - const TDqTaskRunnerSettings& settings, const TLogFunc& logFunc) -{ - return MakeDqTaskRunner(execCtx, settings, logFunc); -} - TKqpTasksRunner::TKqpTasksRunner(google::protobuf::RepeatedPtrField&& tasks, const TDqTaskRunnerContext& execCtx, const TDqTaskRunnerSettings& settings, const TLogFunc& logFunc) @@ -92,7 +86,7 @@ TKqpTasksRunner::TKqpTasksRunner(google::protobuf::RepeatedPtrFieldGetStats()) { Stats.emplace(taskId, stats); } diff --git a/ydb/core/kqp/runtime/kqp_tasks_runner.h b/ydb/core/kqp/runtime/kqp_tasks_runner.h index d9be8de48076..9835aeb4b23f 100644 --- a/ydb/core/kqp/runtime/kqp_tasks_runner.h +++ b/ydb/core/kqp/runtime/kqp_tasks_runner.h @@ -12,9 +12,6 @@ NYql::NDq::IDqOutputConsumer::TPtr KqpBuildOutputConsumer(const NYql::NDqProto:: const NKikimr::NMiniKQL::THolderFactory& holderFactory, TVector&& outputs); -TIntrusivePtr CreateKqpTaskRunner(const NYql::NDq::TDqTaskRunnerContext& execCtx, - const NYql::NDq::TDqTaskRunnerSettings& settings, const NYql::NDq::TLogFunc& logFunc); - class TKqpTasksRunner : public TSimpleRefCount, private TNonCopyable { public: