Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change wallet model should give the ability for a user to select different providers #275

Closed
corydickson opened this issue Sep 22, 2021 · 2 comments · Fixed by #308
Closed

Change wallet model should give the ability for a user to select different providers #275

corydickson opened this issue Sep 22, 2021 · 2 comments · Fixed by #308
Assignees
@mds1
Labels
app Frontend issues POC

Comments

@corydickson
Copy link
Contributor

corydickson commented Sep 22, 2021 •
edited
Loading

Describe the bug
After connecting a wallet via metamask, when a user clicks Change Wallet they are shown a modal that does not have an option to reselect another wallet from the current provider. For usability we may want to add a button that allows the user to disconnect from their current metamask account in the modal.

To Reproduce
Connect a wallet using metamask. In the account dropdown select Change Wallet, no other options are given for a user to reselect metamask and choose a different account via another provider.
@corydickson corydickson changed the title Change wallet model should give the ability for a user to disconnect their current wallet when using metamask Change wallet model should give the ability for a user to select different providers Sep 22, 2021
@apbendi apbendi added the app Frontend issues label Sep 22, 2021
@mds1 mds1 added the POC label Sep 29, 2021
@mds1
Copy link
Contributor

mds1 commented Sep 29, 2021

Just commenting to note the first step here is determining a set of wallets to support, then seeing if this issue is still applicable. Wallets to support:

  • MetaMask / injected web3
  • WalletConnect
  • Others TBD

@phutchins
Copy link
Contributor

Lets move forward with Metamask and WalletConnect and we an scope any other research or wallets after the POC.

@mds1 mds1 mentioned this issue Sep 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mds1 mds1

Labels
app Frontend issues POC
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add walletconnect support dcgtc/dgrants
4 participants
@phutchins @apbendi @corydickson @mds1