Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up validators #197

Closed
dcastil opened this issue Feb 4, 2023 · 1 comment · Fixed by #292
Closed

Clean up validators #197

dcastil opened this issue Feb 4, 2023 · 1 comment · Fixed by #292
Labels
breaking Is breaking change context-v2 Related to tailwind-merge v2 feature Is new feature
Milestone
v2

Comments

@dcastil
Copy link
Owner

dcastil commented Feb 4, 2023 •
edited
Loading

The validators structure is a bit messy at the moment. Some of them check for arbitrary values (isLength, isInteger) and some don't (isTshirtSize, isNumber).

It makes sense not to check for arbitrary values in isLength and isInteger to make validators easier to understand. That makes it a bit more boilerplaty to write the config, but I think making it easier to understand is the better tradeoff.
@dcastil dcastil added breaking Is breaking change feature request labels Feb 4, 2023
@dcastil dcastil added this to the v2 milestone Feb 4, 2023
@dcastil dcastil mentioned this issue Aug 19, 2023
Merged
@github-actions
Copy link

This was addressed in release v2.0.0.

@dcastil dcastil added the context-v2 Related to tailwind-merge v2 label Oct 30, 2023
@dcastil dcastil added feature Is new feature and removed feature request labels Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking Is breaking change context-v2 Related to tailwind-merge v2 feature Is new feature
Projects
None yet
Milestone
v2
Development

Successfully merging a pull request may close this issue.

Separate validators better dcastil/tailwind-merge
1 participant
@dcastil