Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

brush is not resized along with coordinate grid chart #972

Closed
gordonwoodhull opened this issue Aug 5, 2015 · 1 comment
Closed

brush is not resized along with coordinate grid chart #972

gordonwoodhull opened this issue Aug 5, 2015 · 1 comment
Labels
bug
Milestone
non-breaking

Comments

@gordonwoodhull
Copy link
Contributor

@amergin reports:

I noticed that for charts where height is small (in the picture 197px) the brush is drawn incorrectly:
image
I don't remember seeing this bug earlier.

This happens after a resize.
@gordonwoodhull gordonwoodhull added this to the v2.0 milestone Aug 5, 2015
@gordonwoodhull
Copy link
Contributor Author

Both the brush handles and the horizontal extent do not resize correctly when the chart is resized. Not just ugly, but incorrect.

@gordonwoodhull gordonwoodhull mentioned this issue Aug 5, 2015
Closed
gordonwoodhull added a commit that referenced this issue Aug 5, 2015
@gordonwoodhull
better fix for #972
0b91fad 
named transitions and optional transitions are not needed here,
because we can pass the transition instead of the selection

we'll keep the infrastructure for optional and named transitions, though ;-)
@amergin amergin mentioned this issue Aug 11, 2015
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
non-breaking
Development

No branches or pull requests
1 participant
@gordonwoodhull