Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update changelog issue references with links #845

Merged
merged 1 commit into from
Jan 26, 2015

Conversation

mtraynham
Copy link
Contributor

Simple regex find and replace:

#(\d+)

[#$1](https://github.com/dc-js/dc.js/issues/$1)

@gordonwoodhull
Copy link
Contributor

I had hoped that since the changelog is hosted on github, it would use github flavored markdown, but I guess not.

I guess we really are going to need to generate it automatically.

@mtraynham
Copy link
Contributor Author

You can use relative paths, but the issues page is not really a relative path... There might be a way to use markdown link references, but I don't know if you can concat those with strings...

http://daringfireball.net/projects/markdown/syntax#link

  [google]: http://google.com/        "Google"
  [yahoo]:  http://search.yahoo.com/  "Yahoo Search"
  [msn]:    http://search.msn.com/    "MSN Search"

@gordonwoodhull
Copy link
Contributor

Yeah, apparently not:

not this ticket/845

@gordonwoodhull gordonwoodhull merged commit 847965c into dc-js:master Jan 26, 2015
@mtraynham mtraynham deleted the add_changelog_links branch January 26, 2015 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants