Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dataTable customization points #1063

Open
gordonwoodhull opened this issue Dec 14, 2015 · 0 comments
Open

fix dataTable customization points #1063

gordonwoodhull opened this issue Dec 14, 2015 · 0 comments
Labels
Milestone

Comments

@gordonwoodhull
Copy link
Contributor

As noted here, the customization points in the data table are different from usual. The only other place where we expect users to overwrite a method to do normal customization is doClick.

Instead there should be getter/setters. It's great that these all are customizable:

  • _doColumnValueFormat
  • _doColumnHeaderFormat
  • _doColumnHeaderCapitalize
  • _doColumnHeaderFnToString

... but these should be getter/setters

  • formatValue
  • formatHeader
  • capitalizeHeader
  • stringifyHeaderFn

Two options:

  1. Backward-compatible. Keep the public, customizable members but add getters/setters.
  2. Purist. Make them private members, either ignore the old names or make assignment to the old names fail using defineProperty. (Could even deprecate the old setters with a warning, hmmmm.)
@gordonwoodhull gordonwoodhull added this to the v2.1 milestone Dec 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant