Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#168 introduces clone() of rules #172

Open
dburgener opened this issue Apr 13, 2023 · 0 comments
Open

#168 introduces clone() of rules #172

dburgener opened this issue Apr 13, 2023 · 0 comments

Comments

@dburgener
Copy link
Owner

#168

Because of the way lifetimes are handled in rules, introducing the clone() is the expedient way to handle SID extraction, but isn't ideal from a performance standpoint. Ideally, lifetimes inside ValidatedStatements should be cleaned up, but to avoid this clone() and to enable returning the various maps from get_reduced_infos() so we can call generate_sexp() outside and refactor the library API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant