Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADAP-385] [Bug] Negative part_number for dbt.split_part() is not working #688

Closed
3 tasks done
Tracked by #7916
dave-connors-3 opened this issue Mar 19, 2023 · 0 comments · Fixed by #689
Closed
3 tasks done
Tracked by #7916

[ADAP-385] [Bug] Negative part_number for dbt.split_part() is not working #688

dave-connors-3 opened this issue Mar 19, 2023 · 0 comments · Fixed by #689
Labels
type:bug Something isn't working

Comments

@dave-connors-3
Copy link
Contributor

dave-connors-3 commented Mar 19, 2023 •
edited
Loading

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward extension of existing dbt-spark functionality, rather than a Big Idea better suited to a discussion

Describe the feature

like other adapters, this adapter should support negative arguments for part_number in it's implementation of the split_part cross db util.

See details in dbt-labs/dbt-bigquery#615

Describe alternatives you've considered

No response

Who will this benefit?

No response

Are you interested in contributing this feature?

No response

Anything else?

No response
@github-actions github-actions bot changed the title [Feature] allow negative part number args for split_part [ADAP-385] [Feature] allow negative part number args for split_part Mar 19, 2023
@dave-connors-3 dave-connors-3 mentioned this issue Mar 19, 2023
Merged
6 tasks
@dbeatty10 dbeatty10 mentioned this issue Jun 21, 2023
Closed
@dbeatty10 dbeatty10 mentioned this issue Jul 11, 2023
Merged
6 tasks
@dbeatty10 dbeatty10 added type:bug Something isn't working and removed type:enhancement New feature or request labels Jul 11, 2023
@dbeatty10 dbeatty10 changed the title [ADAP-385] [Feature] allow negative part number args for split_part [ADAP-385] [Bug] Negative part_number for dbt.split_part() is not working Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix split part negative part number dbt-labs/dbt-spark
2 participants
@dbeatty10 @dave-connors-3