[ADAP-584] [Bug] Non-conventional Version Check in Setup.py

[DustinMoriarty]

Is this a new bug in dbt-snowflake?

• I believe this is a new bug in dbt-snowflake
• I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior

The setup.py checks the python version using a manual condition statement. This is not conventional python packaging behavior. The package manager is responsible for checking the python version. The python version is documented in the package metadata using the python_requires property. Adding an extra check of the python version deviates from the behavior expected during python packaging.

Expected Behavior

Leave the python_requires setting but remove the condition block.

Steps To Reproduce

Inspect the setup.py.

Relevant log output

No response

Environment

- OS:any
- Python:>=3.7
- dbt-core:any
- dbt-snowflake:1.6.0b2

Additional Context

No response

[Fleid]

Removing triage, I agree this should be considered as part of dbt-labs/dbt-adapters#80
When it's officially added in its scope, we should flag this issue as duplicate.

[DustinMoriarty]

@Fleid : Any thoughts about merging #634 now? Do we need to wait for dbt-labs/dbt-adapters#80?

[Fleid]

I would wait for dbt-labs/dbt-adapters#80 - if anything else to have everything done together.

[github-actions]

This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please comment on the issue or else it will be closed in 7 days.