Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADAP-517] [Bug] latest and 1.x.latest tags for ghcr Docker releases are stale #597

Closed
2 tasks done
Tracked by #7571
scotthenley opened this issue May 8, 2023 · 7 comments
Closed
2 tasks done
Tracked by #7571
Labels
type:bug Something isn't working

Comments

@scotthenley
Copy link

scotthenley commented May 8, 2023

Is this a new bug in dbt-snowflake?

  • I believe this is a new bug in dbt-snowflake
  • I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior

Look at https://github.com/dbt-labs/dbt-snowflake/pkgs/container/dbt-snowflake/versions?filters%5Bversion_type%5D=tagged

1.3.0 container image is still tagged as "latest":

image

Expected Behavior

The most recent stable image version should be tagged as "latest"

Steps To Reproduce

  1. Look at https://github.com/dbt-labs/dbt-snowflake/pkgs/container/dbt-snowflake
  2. 1.3.0 is tagged as latest.

Relevant log output

No response

Environment

- OS:
- Python:
- dbt-core:
- dbt-snowflake:

Additional Context

This is related to #564

I posted a question in the discussions section on March 17 inquiring about this.

@scotthenley scotthenley added type:bug Something isn't working triage:product labels May 8, 2023
@github-actions github-actions bot changed the title [Bug] 1.3.0 container image is tagged as latest, it should be pointing to the most recent stable image version. [ADAP-517] [Bug] 1.3.0 container image is tagged as latest, it should be pointing to the most recent stable image version. May 8, 2023
@dbeatty10
Copy link
Contributor

Thanks for reaching out @scotthenley !

I'm not sure if this got fixed in the last couple hours, but this is showing 1.5.0 for me:

image

And so is here:
image

Could you take a look again and see if this is fixed for you as well?

@scotthenley
Copy link
Author

scotthenley commented May 9, 2023

Hi @dbeatty10

I am still seeing the "latest" tag on the 1.3 image. We use the tag to pull the most recent stable version for various CI processes rather than pinning to a version number.

https://github.com/dbt-labs/dbt-snowflake/pkgs/container/dbt-snowflake/versions?filters%5Bversion_type%5D=tagged

tag

@dbeatty10
Copy link
Contributor

Thanks for that @scotthenley -- I see what you are saying!

I'm guessing this is affecting other dbt adapters as well (dbt-bigquery here, etc).

We've been iterating on our release processes, and this piece probably got lost along the way.

Thank you for letting us know so we can get this up-to-date 🙏

@gxpd-jjh
Copy link

gxpd-jjh commented Dec 8, 2023

@dbeatty10 It is still showing latest as v1.3.0.

@dbeatty10 dbeatty10 changed the title [ADAP-517] [Bug] 1.3.0 container image is tagged as latest, it should be pointing to the most recent stable image version. [ADAP-517] [Bug] latest and 1.x.latest tags for ghcr Docker releases are stale Dec 11, 2023
@mikealfare
Copy link
Contributor

From what we can tell, this tag is being deprecated and we cannot adjust it. Closing as "can't do".

@mikealfare mikealfare closed this as not planned Won't fix, can't repro, duplicate, stale Jan 30, 2024
@dbeatty10
Copy link
Contributor

dbt-labs/dbt-core#9495 fixes the underlying issue (thank you @mikealfare !), and this particular issue will be resolved for each 1.x version of this adapter upon its next patch release.

We are choosing not to address any un-supported versions at this time, so <=1.4.x will not be updated.

Here are the most recent ones for the supported versions of dbt-snowflake in PyPI:

  • 1.7.1
  • 1.6.6
  • 1.5.6

So this will be completely resolved for >=1.5.x when each of the following are released (but only if each is released prior to falling out of support):

  • 1.7.2
  • 1.6.7
  • 1.5.7

@dbeatty10 dbeatty10 reopened this Jan 31, 2024
@dbeatty10 dbeatty10 reopened this Feb 8, 2024
@dbeatty10
Copy link
Contributor

Screenshot of latest and 1.7.latest:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants