Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-1689] Check exceptions #111

Closed
emmyoop opened this issue Dec 20, 2022 · 1 comment
Closed

[CT-1689] Check exceptions #111

emmyoop opened this issue Dec 20, 2022 · 1 comment
Assignees
Labels

Comments

@emmyoop
Copy link
Member

emmyoop commented Dec 20, 2022

dbt-core has deprecated functions to raise exceptions in favor of directly raising the exceptions. Nothing should be broken (yet) and the functions still raise as expected but they also will log a deprecation warning (pending dbt-labs/dbt-core#6413). It would be good to resolve these deprecation messages before the 1.4 rc.

There are a lot of deprecated function so it's easier to search for dbt.exceptions and look at each callsite to determine if it's using a function or already directly raising an exception. Then replace anywhere using functions with directly raising an exception.

We can create new exceptions in dbt-core to raise or the adapters could start to own their own exceptions within the adapter code base that inherit from exceptions in dbt-core.

For examples, see dbt-labs/dbt-core#6347 that replaced all functions with raises.

@emmyoop emmyoop self-assigned this Dec 20, 2022
@github-actions github-actions bot changed the title Check exceptions [CT-1689] Check exceptions Dec 20, 2022
@github-actions
Copy link

This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please remove the stale label or comment on the issue, or it will be closed in 7 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant