Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADAP-699] [Regression] dbt-redshift is susceptible to breaking changes via patch releases to redshift_connector #531

Closed
2 tasks done
dataders opened this issue Jul 13, 2023 · 0 comments · Fixed by #530
Closed
2 tasks done
Labels
type:bug Something isn't working type:regression

Comments

@dataders
Copy link
Contributor

Is this a regression in a recent version of dbt-redshift?

  • I believe this is a regression in dbt-redshift functionality
  • I have searched the existing issues, and I could not find an existing issue for this regression

Current Behavior

Follow up to #518

https://github.com/aws/amazon-redshift-python-driver, a package upon which this repo heavily relies, does not follow Semantic Versioning, despite using three-integer release version names. Instead there's weekly release where the patch number is incremented.

The conventional, Pythonic approach is to compatibility-pin package dependencies to the minor version (~=x.y.z), which allows our users to take advantage of any new, non-breaking, bug fixes shipped in patch releases after we release. This is not possible with redshift_connector.

Instead, we hard-pin to a specific patch, and only consider incrementing the patch version:

  • if there's a user-impacting change in redshift_connector, or
  • whenever we are ourselves releasing a new major or minor version

Expected/Previous Behavior

xxx

Steps To Reproduce

xxx

Relevant log output

No response

Environment

- OS:
- Python:
- dbt-core (working version):
- dbt-redshift (working version):
- dbt-core (regression version):
- dbt-redshift (regression version):

Additional Context

No response

@github-actions github-actions bot changed the title [Regression] dbt-redshift is suceptible to breaking changes via patch releases to redshift_connector [ADAP-699] [Regression] dbt-redshift is suceptible to breaking changes via patch releases to redshift_connector Jul 13, 2023
@dbeatty10 dbeatty10 changed the title [ADAP-699] [Regression] dbt-redshift is suceptible to breaking changes via patch releases to redshift_connector [ADAP-699] [Regression] dbt-redshift is susceptible to breaking changes via patch releases to redshift_connector Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working type:regression
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants