Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dbt-meshify split creates a funk-ily formatted dbt_project.yml file #120

Closed
5 tasks
graciegoheen opened this issue Aug 18, 2023 · 6 comments
Closed
5 tasks
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@graciegoheen
Copy link
Collaborator

Describe the bug

This is nit-picky, but have gotten feedback that it's important to prevent as many manual "fixes" as possible.

When I run the dbt-meshify split command and a new subproject is generated, the dbt_project.yml file that is creates has a weird format. It would be nice if we used the same dbt_project.yml format you get when you run a dbt init to create a new project.

Steps to reproduce

  • run dbt-meshify split command

Expected results

  • a dbt_project.yml file is created with the typical dbt yml format (same as when you run dbt-init)

Actual results

  • a dbt_project.yml file is created with an odd format

Screenshots and log output

Screenshot 2023-08-17 at 5 00 10 PM

System information

Which database are you using dbt with?

  • postgres
  • redshift
  • bigquery
  • snowflake
  • other (specify: ____________)

The output of dbt debug:

<output goes here>

The output of dbt --version:

<output goes here>

Additional context

Are you interested in contributing the fix?

@graciegoheen graciegoheen added bug Something isn't working triage Tis issue or pull request must be triaged by a project maintainer labels Aug 18, 2023
@graciegoheen
Copy link
Collaborator Author

Another thing I found odd here, was that only the folders that we're copying over are create.

In my case, there was no empty folder for tests, seeds, macros, etc. that I'd expect when running a dbt init.

Screenshot 2023-08-17 at 5 01 38 PM

@graciegoheen
Copy link
Collaborator Author

I'd also potentially expect for my .gitignore file to be copied over and an empty / template README to be created

@dave-connors-3
Copy link
Collaborator

oh yeah it's funky as hell 😄 I don't know how much leeway the yml library we're using is going to give us to format the project yml the way we're used to seeing. Very open to suggestions

I'm going to split your folder and other project files suggestion into a separate issue!

@dave-connors-3 dave-connors-3 added enhancement New feature or request and removed bug Something isn't working triage Tis issue or pull request must be triaged by a project maintainer labels Aug 18, 2023
@graciegoheen
Copy link
Collaborator Author

Is there any reason to not just do a dbt init in the new project before pulling stuff over? Is that a better place to start from for a new project? Or is empty easier?

@graciegoheen
Copy link
Collaborator Author

Elize also requested copying over the sqlfluff config file

@nicholasyager
Copy link
Collaborator

Completed in #206

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants