Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better error message for unit test with missing input #9882

Closed
3 tasks done
Tracked by #8283
graciegoheen opened this issue Apr 9, 2024 · 2 comments
Closed
3 tasks done
Tracked by #8283

better error message for unit test with missing input #9882

graciegoheen opened this issue Apr 9, 2024 · 2 comments
Labels
dbt tests Issues related to built-in dbt testing functionality enhancement New feature or request stale Issues that have gone stale unit tests Issues related to built-in dbt unit testing functionality

Comments

@graciegoheen
Copy link
Contributor

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward extension of existing dbt functionality, rather than a Big Idea better suited to a discussion

Describe the feature

Originally from @gwenwindflower:

could i suggest a slight rewording here to make it clear you mean the node hasn't been fixturized ?

Current error message:
Screenshot 2024-04-04 at 1 19 14 PM

Suggestion for improvement:
Depends on a given input called stg_customers which was not provided. or something along those lines

That would:

  • utilize the name of the key that's missing in your YAML config
  • keeping the language consistent (i think using the word fixture might be too far and confuse those unfamiliar with unit tests) with the code
  • while shading the potential meaning away from 'missing node' which to me makes me think about the DAG.

put another way, i think this error totally makes sense if you understand how unit tests work under-the-hood, but we could perhaps optimize it more towards the unit test user vs. the underlying mechanics?

Describe alternatives you've considered

No response

Who will this benefit?

No response

Are you interested in contributing this feature?

No response

Anything else?

No response

@graciegoheen graciegoheen added enhancement New feature or request triage labels Apr 9, 2024
@graciegoheen graciegoheen added dbt tests Issues related to built-in dbt testing functionality and removed triage labels Apr 9, 2024
@dbeatty10 dbeatty10 added the unit tests Issues related to built-in dbt unit testing functionality label Apr 16, 2024
Copy link
Contributor

This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please comment on the issue or else it will be closed in 7 days.

@github-actions github-actions bot added the stale Issues that have gone stale label Oct 14, 2024
Copy link
Contributor

Although we are closing this issue as stale, it's not gone forever. Issues can be reopened if there is renewed community interest. Just add a comment to notify the maintainers.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dbt tests Issues related to built-in dbt testing functionality enhancement New feature or request stale Issues that have gone stale unit tests Issues related to built-in dbt unit testing functionality
Projects
None yet
Development

No branches or pull requests

2 participants