Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clearer no-op logging for saved queries within dbt build --include-saved-query #9533

Closed
Tracked by #9116
jtcohen6 opened this issue Feb 7, 2024 · 0 comments · Fixed by #9605
Closed
Tracked by #9116

Clearer no-op logging for saved queries within dbt build --include-saved-query #9533

jtcohen6 opened this issue Feb 7, 2024 · 0 comments · Fixed by #9605
Assignees
@jtcohen6
Labels
enhancement New feature or request Impact: SL semantic Issues related to the semantic layer
Milestone
v1.8

Comments

@jtcohen6
Copy link
Contributor

jtcohen6 commented Feb 7, 2024 •
edited
Loading

This is really intended as a stubbed method that serves as a placeholder for future SL integration work. It's confusing right now that the logs of dbt build --include-saved-query look like:

10:31:43  1 of 1 START Saved Query saved_query.jaffle_shop.new_customer_orders ........... [RUN]
10:31:43  1 of 1 OK created Saved Query saved_query.jaffle_shop.new_customer_orders ...... [success in 0.00s]

Let's do something closer to this: 321db7a

Screenshot 2024-02-03 at 14 56 17
@jtcohen6 jtcohen6 mentioned this issue Feb 7, 2024
Closed
@jtcohen6 jtcohen6 added semantic Issues related to the semantic layer Impact: SL enhancement New feature or request labels Feb 7, 2024
@martynydbt martynydbt modified the milestones: v1.8, v1.9 Feb 8, 2024
This was referenced Feb 20, 2024
Merged
Closed
@jtcohen6 jtcohen6 self-assigned this Feb 22, 2024
@graciegoheen graciegoheen modified the milestones: v1.9, v1.8 May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jtcohen6 jtcohen6

Labels
enhancement New feature or request Impact: SL semantic Issues related to the semantic layer
Projects
None yet
Milestone
v1.8
Development

Successfully merging a pull request may close this issue.

Clearer no-op logging in stubbed SavedQueryRunner dbt-labs/dbt-core
3 participants
@jtcohen6 @graciegoheen @martynydbt