Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test docs generate catalog includes external nodes if available in 1.6.latest #9481

Open
1 task done
MichelleArk opened this issue Jan 29, 2024 · 0 comments
Open
1 task done

Comments

@MichelleArk
Copy link
Contributor

MichelleArk commented Jan 29, 2024

Housekeeping

  • I am a maintainer of dbt-core

Short description

External nodes should be included in the catalog as a result of dbt docs generate. This is functional in 1.6.latest but is missing a test.

Acceptance criteria

Add a test that ensures external nodes are included in the catalog from docs generate, if they are available in the manifest.

Suggested Tests

Add a test that ensures external nodes are included in the catalog from docs generate, if they are available in the manifest.

Impact to Other Teams

n/a

Will backports be required?

This should be done on 1.6.latest (effectively a backport) because the test files have differed significantly + this has regressed in 1.7 and would cause conflicts to backport directly.

Context

#9458

@MichelleArk MichelleArk added user docs [docs.getdbt.com] Needs better documentation and removed user docs [docs.getdbt.com] Needs better documentation labels Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant