Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CT-1950] Use an Enum instead of a string to represent IncludeExclude.include #6786

Closed
MichelleArk opened this issue Jan 30, 2023 · 1 comment
Closed

[CT-1950] Use an Enum instead of a string to represent IncludeExclude.include #6786

MichelleArk opened this issue Jan 30, 2023 · 1 comment
Assignees
@iknox-fa
Labels
python_api Issues related to dbtRunner Python entry point

Comments

@MichelleArk
Copy link
Contributor

Use an Enum instead of a string in the IncludeExclude dataclass to represent the "all"/"*" options of the include attribute. Shouldn't be a breaking change in terms of the user interface, just internals

Originally posted by @MichelleArk in #6771 (comment)
@MichelleArk MichelleArk added Team:Execution python_api Issues related to dbtRunner Python entry point labels Jan 30, 2023
@github-actions github-actions bot changed the title Use an Enum instead of a string to represent IncludeExclude.include [CT-1950] Use an Enum instead of a string to represent IncludeExclude.include Jan 30, 2023
@MichelleArk MichelleArk mentioned this issue Jan 30, 2023
Merged
6 tasks
@iknox-fa iknox-fa self-assigned this Apr 20, 2023
@iknox-fa
Copy link
Contributor

iknox-fa commented May 6, 2023

Per discussions w @MichelleArk:
We're not really gaining anything by making this an enum so I'm closing the ticket.

@iknox-fa iknox-fa closed this as completed May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iknox-fa iknox-fa

Labels
python_api Issues related to dbtRunner Python entry point
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MichelleArk @iknox-fa