Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-92] [Feature] MergeBehavior extending for adapters by default #4622

Closed
1 task done
McKnight-42 opened this issue Jan 25, 2022 · 3 comments
Closed
1 task done

[CT-92] [Feature] MergeBehavior extending for adapters by default #4622

McKnight-42 opened this issue Jan 25, 2022 · 3 comments
Labels
enhancement New feature or request stale Issues that have gone stale

Comments

@McKnight-42
Copy link
Contributor

McKnight-42 commented Jan 25, 2022

Is there an existing feature request for this?

  • I have searched the existing issues

Describe the Feature

in reference to #105 in dbt-bigquery

questions @jtcohen6 brought up in regards to this:

  • Can adapter-specific configs be defined with non-default MergeBehavior?
  • Could we find a way to let users declare/override the MergeBehavior for a specific config in a specific model?

Some syntax work that has been worked on Custom merge behavior for configs

Describe alternatives you've considered

Current strategy would be duplication of config labels before clobbering in case of bigquery and depending on size of project could be very heavy lift and unclean process

Who will this benefit?

Users who need to be able to change default behavior of the adapter configs to stop things like clobbering of some configs ie. big-query multiple labels.

organization members who don't directly interface with dbt themselves but work from the warehouse side can rely on not losing values and know tables/datasets are organized correctly.

Are you interested in contributing this feature?

Yes would love to work with language team on this

Anything else?

@github-actions github-actions bot changed the title [Feature] MergeBehavior extending for adapters by default [CT-92] [Feature] MergeBehavior extending for adapters by default Jan 25, 2022
@nathaniel-may
Copy link
Contributor

estimation:

  • lots of questions around what our options are
  • unknown unknowns around all ways merge behavior is used in core today
  • unknowns around best ways to leverage the adapter interface
  • recommendation: 3 day spike.

@github-actions
Copy link
Contributor

This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please remove the stale label or comment on the issue, or it will be closed in 7 days.

@github-actions github-actions bot added the stale Issues that have gone stale label Oct 23, 2022
@github-actions
Copy link
Contributor

Although we are closing this issue as stale, it's not gone forever. Issues can be reopened if there is renewed community interest; add a comment to notify the maintainers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale Issues that have gone stale
Projects
None yet
Development

No branches or pull requests

2 participants