Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add update doc method in db_store #322

Merged
merged 14 commits into from
Feb 19, 2023
Merged

feat: add update doc method in db_store #322

merged 14 commits into from
Feb 19, 2023

Conversation

jingchen2222
Copy link
Collaborator

@jingchen2222 jingchen2222 commented Feb 19, 2023

Goal

add update_document method in db_store and related ut

Changes

  • add update_document method
  • add related ut for update documents

@jingchen2222 jingchen2222 self-assigned this Feb 19, 2023
@github-actions github-actions bot added the S-kv label Feb 19, 2023
@jingchen2222 jingchen2222 changed the title feat: update doc feat: update doc WIP Feb 19, 2023
@db3fans
Copy link
Collaborator

db3fans commented Feb 19, 2023

This PR exceeds the recommended size of 1200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions github-actions bot removed the S-kv label Feb 19, 2023
@jingchen2222 jingchen2222 changed the title feat: update doc WIP feat: add update doc method in db_store Feb 19, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 19, 2023

Codecov Report

Merging #322 (308b90c) into main (85c526b) will increase coverage by 1.66%.
The diff coverage is 96.79%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #322      +/-   ##
==========================================
+ Coverage   66.09%   67.76%   +1.66%     
==========================================
  Files          55       55              
  Lines        6616     6992     +376     
==========================================
+ Hits         4373     4738     +365     
- Misses       2243     2254      +11     
Flag Coverage Δ
rust 67.76% <96.79%> (+1.66%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/error/src/lib.rs 100.00% <ø> (ø)
src/node/src/command.rs 46.46% <ø> (-0.15%) ⬇️
src/storage/src/db_store.rs 92.59% <96.79%> (+1.67%) ⬆️
src/types/src/cost.rs 87.17% <100.00%> (+0.16%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants