Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WindowsSecurityContextImpl.java to handle SEC_E_BUFFER_TOO_SMALL #274

Closed
wants to merge 1 commit into from

Conversation

immo7
Copy link
Contributor

@immo7 immo7 commented Oct 28, 2015

Although not documented as a valid return code on MSDN I am now at least the second Waffle user to see a WinError.SEC_E_BUFFER_TOO_SMALL return code in WindowsSecurityContextImpl.initialize. I can confirm that the following patch fixes the problem, but there is no way for a third party to test this because the reason why this seemingly invalid error code is returned and why only to some Windows users is still unknown. The changes themselves are trivial and practically risk-free.
A similar pull request has already been made last year and is still open:
#128 opened on Aug 4, 2014 by kentcb

@dblock
Copy link
Collaborator

dblock commented Oct 28, 2015

To be merged this also needs:

@immo7
Copy link
Contributor Author

immo7 commented Oct 28, 2015

  1. Where should I put the entry in CHANGELOG? As part of v1.8.0?
  2. I don't have any experience with C#. Those changes should probably better be done by someone else.
  3. In what form must I give that confirmation? As proof I can only give you a list of Log Outputs.
    Thanks.

@dblock
Copy link
Collaborator

dblock commented Oct 28, 2015

  1. Add a Next section, please. It should have been part of the previous release.
  2. Well...
  3. Make the change, compile the code, run it, confirm that the problem is actually solved.

@hazendaz
Copy link
Member

@dblock I'm comfortable with this change as it is very low risk and now we have the fix on both ends. I'll merge othe other shortly.

@immo7 I've merged this on 20ea0b4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants