Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup CI #10

Closed
dblock opened this issue Jun 30, 2016 · 8 comments
Closed

Setup CI #10

dblock opened this issue Jun 30, 2016 · 8 comments

Comments

@dblock
Copy link
Owner

dblock commented Jun 30, 2016

https://ci.appveyor.com/project/dblock/log4jna

maybe http://www.yegor256.com/2015/01/10/windows-appveyor-maven.html?

@claudiow
Copy link
Contributor

claudiow commented Jun 30, 2016

Based on oshi and thinking on having the dblock projects consistent, what about https://travis-ci.org/dblock/oshi/ and https://travis-ci.org/dblock/log4jna/?

This will enable you to create a dblock-parent and keep a consistent set of ci configurations like:

<ciManagement>
  <system>travis</system>
  <url>https://travis-ci.org/dblock/${project.artifatctId}/</url>
</ciManagement>

Which translates to each project ci location when you run maven.

BTW can we open a conversation about ci and maven central all together? Almost all of this can be based from oshi and is related.

@dblock
Copy link
Owner Author

dblock commented Jul 1, 2016

You can't use Travis because they don't have Windows and I'd love to see tests actually run, that's why I am suggesting AppVeyor. What do you think?

I want you to take some initiative here and try things! Instead of asking for permission ask for forgiveness and it's totally cool to try something, fail, iterate. I'm here to help.

@claudiow
Copy link
Contributor

claudiow commented Jul 1, 2016

Ok testing is more important than consistency.

I'm speculating here but I don't see how a 3rd party will allow us to write into the registry to run those test.

Unfortunately this are more integration tests than unit test and you need elevated permissions to access the registry, most probably the test will fail even in a windows ci environment.

Given that you already have an account with appveyor, Can you contact support and see if they can do anything for us?

I'm investigating if there is a way of mocking the registry write/read process to create unit tests,

@dblock
Copy link
Owner Author

dblock commented Jul 2, 2016

AppVeyor's builds run with administrative privileges on isolated VMs. Problem solved.

@claudiow
Copy link
Contributor

claudiow commented Jul 3, 2016

Ok, I created my account in appveyor,

Can you please add my user claudiow to the project.

Also how do I proceed for now on? Do i continue on my fork with a new pull request or do I work in master?

@dblock
Copy link
Owner Author

dblock commented Jul 4, 2016

I've added you to log4jna, welcome!

You should continue making pull requests, please, even though you have access. You can code review and merge other people's contributions.

Try getting the build running - the pull requests are automatically built when you make/update them.

@claudiow
Copy link
Contributor

claudiow commented Jul 4, 2016

I cant access https://ci.appveyor.com/project/dblock/log4jna. I think that I can't use my AppVeyor user to see the project, I could not find how to do it at AppVeyor site.

In the meantime I'm using https://ci.appveyor.com/project/claudiow/log4jna.

This is in a very early stage and full of errors that I'm investigating.

@dblock
Copy link
Owner Author

dblock commented Jul 4, 2016

I don't think you need to access that project or edit it, commit an appveyor.yml and do all the config there. If you do it on your fork, you can see it on https://ci.appveyor.com/project/claudiow/log4jna (as you said), if you make pull requests you can see the output in https://ci.appveyor.com/project/dblock/log4jna. Bottom line I've never used their UI to setup anything.

@dblock dblock closed this as completed in 6c249df Jul 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants