fix: unhandled error event on connection

Signed-off-by: William F Wheeler II <bill@quickbrownfoxlabs.com>
db-migrate · Jan 27, 2018 · c19d201 · c19d201
1 parent 8c4fb9f
commit c19d201
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 2 deletions.
diff --git a/index.js b/index.js
@@ -16,7 +16,6 @@ var PgDriver = Base.extend({
         this.internals = intern;
         this.connection = connection;
         this.schema = schema || "public";
-        this.connection.connect();
     },
 
     startMigration: function(cb){
@@ -517,7 +516,12 @@ exports.connect = function(config, intern, callback) {
 
     if (config.native) { pg = pg.native; }
     var db = config.db || new pg.Client(config);
-    callback(null, new PgDriver(db, config.schema, intern));
+    db.connect(function(err) {
+      if(err) {
+        callback(err);
+      }
+      callback(null, new PgDriver(db, config.schema, intern));
+    });
 };
 
 exports.base = PgDriver;
diff --git a/test/pg_test.js b/test/pg_test.js
@@ -34,6 +34,16 @@ vows.describe('pg').addBatch({
       db = _db;
     }
   }
+}).addBatch({
+  'connect error': {
+    topic: function () {
+      driver.connect({host: 'fakehost'}, internals, this.callback);
+    },
+
+    'shows connection error': function (err, _db) {
+      assert.isNotNull(err);
+    }
+  }
 }).addBatch({
   'createTable': {
     topic: function() {