Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tvOS Support #121

Closed
imann24 opened this issue Oct 17, 2018 · 8 comments
Closed

tvOS Support #121

imann24 opened this issue Oct 17, 2018 · 8 comments
Labels

Comments

@imann24
Copy link

imann24 commented Oct 17, 2018

Hi, does this package support tvOS?

@dsrees
Copy link
Collaborator

dsrees commented Oct 17, 2018

@imann24 I have not personally tested this or made efforts to guarantee its support. Feel free to try it out and let me know how it goes. I'd be happy to have support added

@imann24
Copy link
Author

imann24 commented Oct 18, 2018

Sounds good! Will keep you posted if I get the chance to verify.

@jklp
Copy link
Contributor

jklp commented Aug 15, 2019

@imann24 I've created a PR at #141 which is now running on our live Apple TV app. The only problem is the Travis build is failing because Jazzy was commented out in the Gemfile in the prior commit without the Gemfile.lock being updated (8e476c2).

I'm hesitant to add an updated Gemfile.lock to my PR in case there was a reason it wasn't updated in the previous commmit - but if you could have a look and let me know if they're any changes I need to make before it's merged?

Thanks
Jerrold

@imann24
Copy link
Author

imann24 commented Aug 15, 2019

Hi! I haven't had the chance to integrate our tvOS app w/ this client (or with Phoenix Framework unfortunately).

If I happen to start the work back up, more than happy to dig in to your PR. Otherwise, not sure I'm a great subject matter expert here.

I assume @dsrees can speak to the Travis issue?

@jklp
Copy link
Contributor

jklp commented Aug 15, 2019

Oh my apologies, I replied to the wrong person! Yes was meant to @reply dsress

@imann24
Copy link
Author

imann24 commented Aug 15, 2019

No worries!

@dsrees
Copy link
Collaborator

dsrees commented Aug 19, 2019

Hey guys, sorry for the delay and for not getting to that PR sooner. Jazzy was messing up something a few months back, i believe it's safe to get it updated. I'll take a look into this

@dsrees
Copy link
Collaborator

dsrees commented Sep 3, 2019

Just released v1.1.1 with @jklp changes

@dsrees dsrees closed this as completed Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants