refactor(api): replace getSession

For no reason, tests are now failing with NextAuth 4.22.0. I came across this: nextauthjs/next-auth#7199 so I gave it a try and it worked!
davidlag0 · Apr 13, 2023 · cfb6efe · cfb6efe
1 parent f1891fb
commit cfb6efe
Show file tree

Hide file tree

Showing 6 changed files with 45 additions and 23 deletions.
diff --git a/__tests__/unit/api/tasks/[taskId].test.js b/__tests__/unit/api/tasks/[taskId].test.js
@@ -1,10 +1,18 @@
 import { createMocks } from "node-mocks-http";
 import handle from "../../../../pages/api/tasks/[taskId]";
-import { getSession } from "next-auth/react";
+import { getServerSession } from "next-auth/next";
 import { prismaMock } from "../../../../lib/prismaMockSingleton";
 
-jest.mock("next-auth/react");
 jest.mock("next-auth/jwt");
+jest.mock("next-auth/next", () => {
+  const originalModule = jest.requireActual("next-auth/next");
+
+  return {
+    __esModule: true,
+    ...originalModule,
+    getServerSession: jest.fn(),
+  };
+});
 
 const testSession = {
   user: {
@@ -32,7 +40,7 @@ describe("/api/tasks/[taskId]", () => {
       },
     });
 
-    getSession.mockReturnValue(null);
+    getServerSession.mockReturnValue(null);
 
     await handle(req, res);
 
@@ -52,7 +60,7 @@ describe("/api/tasks/[taskId]", () => {
       },
     });
 
-    getSession.mockReturnValue({});
+    getServerSession.mockReturnValue({});
 
     await handle(req, res);
 
@@ -72,7 +80,7 @@ describe("/api/tasks/[taskId]", () => {
       },
     });
 
-    getSession.mockReturnValue(testSession);
+    getServerSession.mockReturnValue(testSession);
 
     prismaMock.task.findUnique.mockResolvedValue(null);
 
@@ -94,7 +102,7 @@ describe("/api/tasks/[taskId]", () => {
       },
     });
 
-    getSession.mockReturnValue(testSession);
+    getServerSession.mockReturnValue(testSession);
 
     prismaMock.task.findUnique.mockResolvedValue(testTask);
 
@@ -115,7 +123,7 @@ describe("/api/tasks/[taskId]", () => {
       },
     });
 
-    getSession.mockReturnValue(testSession);
+    getServerSession.mockReturnValue(testSession);
 
     prismaMock.task.delete.mockResolvedValue(testTask);
 

diff --git a/__tests__/unit/api/tasks/index.test.js b/__tests__/unit/api/tasks/index.test.js
@@ -1,10 +1,18 @@
 import { createMocks } from "node-mocks-http";
 import handle from "../../../../pages/api/tasks/index";
-import { getSession } from "next-auth/react";
+import { getServerSession } from "next-auth/next";
 import { prismaMock } from "../../../../lib/prismaMockSingleton";
 
-jest.mock("next-auth/react");
 jest.mock("next-auth/jwt");
+jest.mock("next-auth/next", () => {
+  const originalModule = jest.requireActual("next-auth/next");
+
+  return {
+    __esModule: true,
+    ...originalModule,
+    getServerSession: jest.fn(),
+  };
+});
 
 const testSession = {
   user: {
@@ -31,7 +39,7 @@ describe("/api/tasks/", () => {
       method: "GET",
     });
 
-    getSession.mockReturnValue(null);
+    getServerSession.mockReturnValue(null);
 
     await handle(req, res);
 
@@ -48,7 +56,7 @@ describe("/api/tasks/", () => {
       method: "UNSUPPORTED",
     });
 
-    getSession.mockReturnValue({});
+    getServerSession.mockReturnValue(testSession);
 
     await handle(req, res);
 
@@ -66,7 +74,7 @@ describe("/api/tasks/", () => {
       body: { name: "Test Task" },
     });
 
-    getSession.mockReturnValue(testSession);
+    getServerSession.mockReturnValue(testSession);
 
     prismaMock.task.create.mockResolvedValue(testTask);
 
@@ -83,7 +91,7 @@ describe("/api/tasks/", () => {
       method: "POST",
     });
 
-    getSession.mockReturnValue(testSession);
+    getServerSession.mockReturnValue(testSession);
 
     await handle(req, res);
 
@@ -102,7 +110,7 @@ describe("/api/tasks/", () => {
       body: { "other data": "some data" },
     });
 
-    getSession.mockReturnValue(testSession);
+    getServerSession.mockReturnValue(testSession);
 
     await handle(req, res);
 
@@ -120,7 +128,7 @@ describe("/api/tasks/", () => {
       method: "GET",
     });
 
-    getSession.mockReturnValue(testSession);
+    getServerSession.mockReturnValue(testSession);
 
     prismaMock.task.findMany.mockResolvedValue([]);
 
@@ -139,7 +147,7 @@ describe("/api/tasks/", () => {
       method: "GET",
     });
 
-    getSession.mockReturnValue(testSession);
+    getServerSession.mockReturnValue(testSession);
 
     prismaMock.task.findMany.mockResolvedValue([testTask]);
 
@@ -156,7 +164,7 @@ describe("/api/tasks/", () => {
       method: "GET",
     });
 
-    getSession.mockReturnValue(testSession);
+    getServerSession.mockReturnValue(testSession);
 
     prismaMock.task.findMany.mockResolvedValue([testTask, testTask2]);
 

diff --git a/jest.config.js b/jest.config.js
@@ -23,6 +23,8 @@ const customJestConfig = {
     "^jose$": require.resolve("jose"),
     "^@panva/hkdf$": require.resolve("@panva/hkdf"),
     "^uuid$": require.resolve("uuid"),
+    "^preact-render-to-string$": require.resolve("preact-render-to-string"),
+    "^preact$": require.resolve("preact"),
   },
   testPathIgnorePatterns: ["<rootDir>/cypress/"],
 };

diff --git a/pages/api/auth/[...nextauth].js b/pages/api/auth/[...nextauth].js
@@ -2,7 +2,7 @@ import NextAuth from "next-auth";
 import GithubProvider from "next-auth/providers/github";
 import prisma from "../../../lib/prisma";
 
-export default NextAuth({
+export const authOptions = {
   providers: [
     GithubProvider({
       clientId: process.env.GITHUB_ID,
@@ -30,4 +30,6 @@ export default NextAuth({
       return token;
     },
   },
-});
+};
+
+export default NextAuth(authOptions);
diff --git a/pages/api/tasks/[taskId].js b/pages/api/tasks/[taskId].js
@@ -1,8 +1,9 @@
+import { authOptions } from "../auth/[...nextauth]";
 import prisma from "../../../lib/prisma";
-import { getSession } from "next-auth/react";
+import { getServerSession } from "next-auth/next";
 
 export default async function handle(req, res) {
-  const session = await getSession({ req });
+  const session = await getServerSession(req, res, authOptions);
 
   if (session) {
     if (req.method === "GET") {

diff --git a/pages/api/tasks/index.js b/pages/api/tasks/index.js
@@ -1,10 +1,11 @@
+import { authOptions } from "../auth/[...nextauth]";
 import prisma from "../../../lib/prisma";
-import { getSession } from "next-auth/react";
+import { getServerSession } from "next-auth/next";
 
 const secret = process.env.NEXTAUTH_SECRET;
 
 export default async function handle(req, res) {
-  const session = await getSession({ req });
+  const session = await getServerSession(req, res, authOptions);
 
   if (session) {
     if (req.method === "GET") {