Allow lowercase <iframe> tags for XHTML complience #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In HTML `element.tagName` is returned in upper-case, but in XHTML it is returned [as it is defined in the document](https://developer.mozilla.org/en-US/docs/Web/API/Element.tagName#Notes). As XHTML pages are required to have their element names in lower case, as per the [W3C XHTML Spec](http://www.w3.org/TR/xhtml1/#h-4.2), the current code doesn't work in XHTML. I'm not being pedantic and I don't mean to enforce a style choice either, it's just that browsers do not recognise the tag <IFRAME> when the page is served as XHTML.
davidjbradshaw
added a commit
that referenced
this pull request
Jun 30, 2014
Allow lowercase <iframe> tags for XHTML complience
|
Thanks for the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In HTML
element.tagNameis returned in upper-case, but in XHTML it is returned as it is defined in the document.As XHTML pages are required to have their element names in lower case, as per the W3C XHTML Spec, the current code doesn't work in XHTML.
I'm not being pedantic and I don't mean to enforce a style choice either, it's just that browsers do not recognise the tag <IFRAME> when the page is served as XHTML.
Kudos for using the AMD define() though! Thanks!