Don't break when included more than once on host page #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
May 14, 2015 15:32
|
Thanks for this, looks good. Just wondering if we should throw a warning message if the script is loaded twice. |
|
@davidjbradshaw, good idea - as long as it can be suppressed via configuration too. My use case is just that: I have no idea how many times the host script can be included on a page - and it must just work. |
|
Released v2.8.7. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #190
I added two tests, both referencing
../src/iframeResizer.js(unlike the rest of the tests where its../js/iframeResizer.js) because otherwise one of the (existing) tests failed.I also had some trouble minifying - so I skipped that too.