Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CommonJS support #107

Closed
htchaan opened this issue Oct 20, 2014 · 4 comments
Closed

CommonJS support #107

htchaan opened this issue Oct 20, 2014 · 4 comments

Comments

@htchaan
Copy link

htchaan commented Oct 20, 2014

It would be nice for those using nodejs and browserify 👍
https://github.com/davidjbradshaw/iframe-resizer/blob/master/src/iframeResizer.js#L436
https://github.com/umdjs/umd/blob/master/commonjsStrictGlobal.js

@davidjbradshaw
Copy link
Owner

Happy to accept a patch for this.

@davidjbradshaw
Copy link
Owner

I've added NodeJS support to the current AMD definition to v2.6.5, note that AMD only supports the native call and not jQuery version as it's not possible to define both via AMD.

Would be grateful if you could test this for me, as I don't use Browserify.

@stefanmaric
Copy link

Works fine with Browserify. 👍

@davidjbradshaw
Copy link
Owner

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants