Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fractional parts are missed during the parsing message data #1017

Closed
Blacknikomo opened this issue Nov 26, 2021 · 4 comments
Closed

Fractional parts are missed during the parsing message data #1017

Blacknikomo opened this issue Nov 26, 2021 · 4 comments
Labels

Comments

@Blacknikomo
Copy link

Describe the bug
In our environment, we use iframeResizer to embed snippets in the UI. Sometimes the height calculated with "taggedElement" is a fractional number, e.g. 89.5px.

Whenever the host instance receives the message, it parses the value using the parseInt, so the 89.5px transforms to 89px. In case the content has a border, the bottom part is hidden.

Expected behavior
Host uses parseFloat

Screenshots
image

Additional context
Add any other context about the problem here.

@davidjbradshaw
Copy link
Owner

Happy to take a PR for this

@Blacknikomo
Copy link
Author

Hi @davidjbradshaw. Thanks for the quick reply.
I try to push a commit to a separate branch but receive rejection due to the lack of access rights.
Would you prefer to have an IDEA-based patch?

@davidjbradshaw
Copy link
Owner

Just a normal PR should be fine and sorry for late reply, I have been somewhat unwell of late

@davidjbradshaw
Copy link
Owner

Fixed in v5.0..0 #1205

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants