Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] Add `!default" to allow sass color overwrites #127

Closed
jonashoechst opened this issue Apr 29, 2019 · 3 comments · Fixed by #129
Closed

[Proposal] Add `!default" to allow sass color overwrites #127

jonashoechst opened this issue Apr 29, 2019 · 3 comments · Fixed by #129
Assignees

Comments

@jonashoechst
Copy link
Contributor

Adding a !default tag to the defined variables allows the users to overwrite the variables in a file importing the theme.

This is especially useful when using the theme as a GitHub pages remote theme.

The change was also discussed and implemented for the cayman theme: pages-themes/cayman#11

Thank you for considering!

@daviddarnes
Copy link
Owner

I didn't know this was caused them to work like that! Will definitely add this in when I get a chance, thanks @jonashoechst

@jonashoechst
Copy link
Contributor Author

jonashoechst commented May 22, 2019

Thanks for the enhancement. However you seem to have missed $accentColour, is this by accident?

@daviddarnes
Copy link
Owner

@jonashoechst urgh sorry, this was by accident. Hopefully get to it soon, however feel free to make a pull request to fix it! 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants