Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Add 'exclude all' command that excludes every hint on a page. #183

Closed
swissmas opened this issue Aug 15, 2023 · 1 comment · Fixed by #201
Closed

Feature Request: Add 'exclude all' command that excludes every hint on a page. #183

swissmas opened this issue Aug 15, 2023 · 1 comment · Fixed by #201
Milestone

Comments

@swissmas
Copy link

I want to be able to have a very small amount of custom hints on certain pages. In order to do this now, on pages with a large amount of hints I need to spend a lot of time excluding hints. It would be easier if their were an 'exclude all' command that automatically excluded every hint on the page, that way I can save time by just including the few hints I do want instead of having to exclude the large majority of hints I don't want.

@david-tejada
Copy link
Owner

This is something I thought about when implementing custom hints but I wasn't sure if there was the need for it.

I need to think about the workflow and what happens when an element matches both an include and exclude selector, because I think now exclusion wins. So excluding all and then including some would still leave no hints.

@david-tejada david-tejada linked a pull request Oct 6, 2023 that will close this issue
@david-tejada david-tejada added this to the v0.6.0 milestone Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants