Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bids extractor: succeptable to symlinks in the path #54

Open
yarikoptic opened this issue Feb 12, 2018 · 1 comment
Open

bids extractor: succeptable to symlinks in the path #54

yarikoptic opened this issue Feb 12, 2018 · 1 comment

Comments

@yarikoptic
Copy link
Member

What is the problem?

it seems that somewhere paths resolution/matching is happening and symlinks in the path gets resolved but not "consistently", which results in tests failing for me -- don't those test run also on travis in a similar setup???

$> TMPDIR=/tmp python -m nose -s -v --pdb datalad/metadata/extractors/tests/test_bids.py 
datalad.metadata.extractors.tests.test_bids.test_get_metadata ... ok
datalad.metadata.extractors.tests.test_bids.test_get_metadata_with_README ... ok
datalad.metadata.extractors.tests.test_bids.test_get_metadata_with_description_and_README ... ok
Versions: appdirs=1.4.3 boto=2.44.0 cmd:annex=6.20180206+gitg638032f3a-1~ndall+1 cmd:git=2.11.0 cmd:system-git=2.15.1 cmd:system-ssh=7.6p1 git=2.1.8 gitdb=2.0.2 humanize=0.5.1 iso8601=0.1.11 msgpack=0.4.8 requests=2.18.4 scrapy=1.4.0 six=1.11.0 tqdm=4.19.5 wrapt=1.10.11

----------------------------------------------------------------------
Ran 3 tests in 3.322s

OK

passes, but with symlinked /tmp/ -- fail!:

$> TMPDIR=$HOME/.tmp python -m nose -s -v --pdb datalad/metadata/extractors/tests/test_bids.py 
datalad.metadata.extractors.tests.test_bids.test_get_metadata ... > /home/yoh/proj/bids/pybids/bids/grabbids/bids_layout.py(64)_get_nearest_helper()
-> if 'type' not in self.files[path].entities:
(Pdb) p self.files
{}
@mih
Copy link
Member

mih commented Mar 20, 2018

Please see datalad/datalad#2326 for a related RF.

@mih mih transferred this issue from datalad/datalad Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants