Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Kubebuilder structure #24

Closed
itamar-marom opened this issue Mar 10, 2023 · 4 comments · Fixed by #27
Closed

Question: Kubebuilder structure #24

itamar-marom opened this issue Mar 10, 2023 · 4 comments · Fixed by #27

Comments

@itamar-marom
Copy link
Collaborator

Why did you choose to move from Kubebuilder's default directories structure? As soon as you need to add a new API, you will need to make lots of changes in order to fit the current custom structure. I'm mainly talking about the deploy directory, but the Makefile also.

@itamar-marom
Copy link
Collaborator Author

The Makefile also doesn't look fit to the current structure. For instance, the install and deploy commands are still using Kubebuilder's default structure.

@AdheipSingh
Copy link
Contributor

AdheipSingh commented Mar 10, 2023

@itamar-marom
Project was initally bootstraped on operator-sdk and then moved to kubebuilder. The directory structured has been bootstrapped only once, since then we haven't changed any directory. kubebuilder latest version might have different directory structure.
What issue are you having with Makefile, we can improve on those if you see any issue

@itamar-marom
Copy link
Collaborator Author

itamar-marom commented Mar 10, 2023

@AdheipSingh Looking at the PROJECT file you're using Kubebuilder v2 which has a different structure. I currently don't have any problems since I only started to look at this project today. It is just not following the Kubebuilder structure. I don't mind doing the refactor myself and even upgrading this project to V3 which is newer.

I asked that in the druid-operator Slack channel, but I would ask you here also: "...Since I have more questions coming, I wanted to ask you what is your preferred way for you to get questions? Do you prefer us to ask here? or open GitHub issues?"

@AdheipSingh
Copy link
Contributor

I don't mind doing the refactor myself and even upgrading this project to V3 which is newer.

i personally haven't been strict in following kubebuilder dir structure. regardless, the go mod and the libraries are updated frequently with respect to k8s versions.

druid-operator Slack channel, but I would ask you here also: "...Since I have more questions coming, I wanted to ask you

what is your preferred way for you to get questions?
I am active in all the channels. Feel free to open issues. The more the discussion the better.

I will take a note of your issue. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants