From e7693f85a0f0f1acdb1f8bfb021b4476d65aff2b Mon Sep 17 00:00:00 2001 From: Salih Can Date: Fri, 29 Jul 2022 22:34:04 +0300 Subject: [PATCH 1/2] [analytics-tab] fix analytics tab config variable for gms --- docker/datahub-gms/env/docker.env | 2 +- metadata-service/factories/src/main/resources/application.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docker/datahub-gms/env/docker.env b/docker/datahub-gms/env/docker.env index 8a725b3a3e495e..cacb387281527d 100644 --- a/docker/datahub-gms/env/docker.env +++ b/docker/datahub-gms/env/docker.env @@ -64,7 +64,7 @@ UI_INGESTION_DEFAULT_CLI_VERSION=0.8.41 # ELASTICSEARCH_PASSWORD= # To disable Analytics on the UI -# ANALYTICS_ENABLED=false +# DATAHUB_ANALYTICS_ENABLED=false # Encryption of DataHub Secrets # SECRET_SERVICE_ENCRYPTION_KEY= diff --git a/metadata-service/factories/src/main/resources/application.yml b/metadata-service/factories/src/main/resources/application.yml index 57da380ad8f300..54a9c7ee5c195c 100644 --- a/metadata-service/factories/src/main/resources/application.yml +++ b/metadata-service/factories/src/main/resources/application.yml @@ -85,7 +85,7 @@ configEntityRegistry: path: ${ENTITY_REGISTRY_CONFIG_PATH:../../metadata-models/src/main/resources/entity-registry.yml} platformAnalytics: - enabled: ${ANALYTICS_ENABLED:true} + enabled: ${DATAHUB_ANALYTICS_ENABLED:true} visualConfig: assets: From 9eab1755ca72e50c9feed5211cc0cff1423ec5d8 Mon Sep 17 00:00:00 2001 From: Salih Can Date: Tue, 2 Aug 2022 14:05:20 +0300 Subject: [PATCH 2/2] docs(analytics-tab) Add breaking change note for gms env var --- docs/how/updating-datahub.md | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/how/updating-datahub.md b/docs/how/updating-datahub.md index 480c8b2bbed914..1ebee1353d5574 100644 --- a/docs/how/updating-datahub.md +++ b/docs/how/updating-datahub.md @@ -8,6 +8,7 @@ This file documents any backwards-incompatible changes in DataHub and assists pe - #5451 `GMS_HOST` and `GMS_PORT` environment variables deprecated in `v0.8.39` have been removed. Use `DATAHUB_GMS_HOST` and `DATAHUB_GMS_PORT` instead. - #5478 DataHub CLI `delete` command when used with `--hard` option will delete soft-deleted entities which match the other filters given. - #5471 Looker now populates `userEmail` in dashboard user usage stats. This version of looker connnector will not work with older version of **datahub-gms** if you have `extract_usage_history` looker config enabled. +- #5529 - `ANALYTICS_ENABLED` environment variable in **datahub-gms** is now deprecated. Use `DATAHUB_ANALYTICS_ENABLED` instead. ### Potential Downtime