Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Airflow 2.3.3 compatibility #5593

Closed
stijndehaes opened this issue Aug 9, 2022 · 2 comments
Closed

Airflow 2.3.3 compatibility #5593

stijndehaes opened this issue Aug 9, 2022 · 2 comments
Assignees
Labels
airflow bug Bug report devops PR or Issue related to DataHub backend & deployment

Comments

@stijndehaes
Copy link
Contributor

Describe the bug
The following packages:

acryl-datahub==0.8.42
acryl-datahub[datahub-rest]==0.8.42
acryl-datahub[datahub-kafka]==0.8.42

Can not be installed together with Airflow 2.3.3.

markupsafe>=1.1.1 (from apache-airflow==2.3.3->-r requirements-2.in (line 6))
MarkupSafe>=0.23 (from jinja2==2.11.3->apache-airflow==2.3.3->-r requirements-2.in (line 6))
markupsafe<=2.0.1,>=1.1.1 (from acryl-datahub[datahub-kafka,datahub-rest]==0.8.42->-r requirements-2.in (line 10))
MarkupSafe>=2.1.1 (from werkzeug==2.2.2->apache-airflow==2.3.3->-r requirements-2.in (line 6))

To Reproduce
Steps to reproduce the behavior:

  1. create virtual env
  2. pip install airflow==2.3.3
  3. pip install acryl-datahub==0.8.42

Expected behavior
I expect to be able to combine the 2.

I noticed markupsafe was pinned to <= 2.0.1 because of issues with jinja:
#4188

And update to be compatible with Airflow:
#4388

However I do not have enough experience with this project to know if updating markupsafe is "safe"

Screenshots
NA

Desktop (please complete the following information):
NA

Additional context
NA

@stijndehaes stijndehaes added the bug Bug report label Aug 9, 2022
@maggiehays maggiehays added the product PR or Issue related to the DataHub UI/UX label Aug 9, 2022
@maggiehays maggiehays added devops PR or Issue related to DataHub backend & deployment and removed product PR or Issue related to the DataHub UI/UX labels Aug 9, 2022
@KulykDmytro
Copy link
Contributor

seems like dup #4809

@hsheth2
Copy link
Collaborator

hsheth2 commented Aug 10, 2022

Yup this is a dup - thanks for calling that out. We'll close this one and track it in the other issue.

We have been looking into the issue and will be back with more updates soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
airflow bug Bug report devops PR or Issue related to DataHub backend & deployment
Projects
None yet
Development

No branches or pull requests

4 participants