Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Progress Bar #32

Closed
kaifronsdal opened this issue Jun 28, 2024 · 1 comment
Closed

Adding Progress Bar #32

kaifronsdal opened this issue Jun 28, 2024 · 1 comment
Labels
enhancement New feature or request wontfix This will not be worked on

Comments

@kaifronsdal
Copy link

Currently datadreamer seems to rely on occasional messages to indicate the current progress/amount of time left such as:

Step '********' progress: 90% 🔄 (Estimated time left: 28 secs)

However, it would be nice to have the option of using a progress bar instead such as tqdm (which can also display other information such as loss/error rates during finetuning) that other libraries like HuggingFace Trainers use. Right now, there isn't even a way to reenable model's default progress bar if desired. For instance, the vLLM wrapper hardcodes use_tqdm=False.

@AjayP13
Copy link
Collaborator

AjayP13 commented Aug 1, 2024

Thanks for the suggestion. I think I'd like to keep the progress printing the way it is. The library has options for the interval at which it prints also (default is 60 seconds).

I mostly chose this design because tqdm, while nice for interactive use on a Terminal, is awful in research settings when submitting a script to a cluster and having it write the output to a log file, where tqdm tends to output way too many lines and creates a mess in the logs due to the way it writes tot he terminal.

That being said, I have made it so you can re-enable the original logs of libraries. For example, you can see here that DataDreamer takes in hf_log which you can set hf_log=True to re-enable all Hugging Face library logs. You can also set verbose=True to re-enable logs from other libraries like VLLM. I just enabled that in the latest version of DataDreamer.

Hope that helps!

@AjayP13 AjayP13 closed this as completed Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants